-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-6239: Added Content Type for Image Variation #105
Merged
Steveb-p
merged 3 commits into
1.3
from
bugfix/IBX-6239-wrong-content-type-for-binary-rest
Sep 20, 2023
Merged
IBX-6239: Added Content Type for Image Variation #105
Steveb-p
merged 3 commits into
1.3
from
bugfix/IBX-6239-wrong-content-type-for-binary-rest
Sep 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisztof
force-pushed
the
bugfix/IBX-6239-wrong-content-type-for-binary-rest
branch
2 times, most recently
from
August 30, 2023 11:38
f3fef9c
to
fd50113
Compare
kisztof
force-pushed
the
bugfix/IBX-6239-wrong-content-type-for-binary-rest
branch
2 times, most recently
from
August 30, 2023 12:07
9ae64cd
to
b31331c
Compare
kisztof
force-pushed
the
bugfix/IBX-6239-wrong-content-type-for-binary-rest
branch
from
August 30, 2023 12:46
b31331c
to
261cced
Compare
Steveb-p
reviewed
Aug 30, 2023
alongosz
reviewed
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kisztof almost ok 💪
see the review and also Steve's comments.
webhdx
suggested changes
Sep 12, 2023
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
webhdx
approved these changes
Sep 13, 2023
mikadamczyk
approved these changes
Sep 13, 2023
alongosz
approved these changes
Sep 13, 2023
ciastektk
approved these changes
Sep 13, 2023
konradoboza
approved these changes
Sep 14, 2023
katarzynazawada
approved these changes
Sep 20, 2023
Steveb-p
deleted the
bugfix/IBX-6239-wrong-content-type-for-binary-rest
branch
September 20, 2023 09:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.3
Summary
This PR updates the Content-Type header in the image variation endpoint(
/api/ezp/v2/content/binary/images/270-999-1/variations/medium
) and adds an integration test for it.Changes
text/html
toapplication/vnd.ez.api.ContentImageVariation+xml
.TODO:
$ composer fix-cs
).